Skip to content

ENT-12600: configure: Documented and refactored script #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 27, 2025
Merged

ENT-12600: configure: Documented and refactored script #1777

merged 9 commits into from
Aug 27, 2025

Conversation

@larsewi
Copy link
Contributor

@larsewi larsewi commented Jun 24, 2025 •
edited
Loading

  • configure: Removed code duplication
  • configure: Reformatted case statements for consistency
  • configure: Remove CODE_COVERAGE build type
  • configure: Fixed shellcheck issues
  • configure: Decrease verbosity of script

Example output:

 ---snip---
configure: debug: running configure on core repo...
configure: debug: running configure on enterprise repo...
configure: debug: running configure on nova repo...
Error: Failed to run: env CFLAGS=-g2 -O1  ./configure --prefix=/var/cfengine --libdir=/var/cfengine/lib --with-workdir=/var/cfengine --sysconfdir=/etc --with-openssl=/var/cfengine --with-pcre2=/var/cfengine --with-librsync=/var/cfengine --with-init-script --with-lmdb=/var/cfengine --without-pthreads-w32 --with-ldap=/var/cfengine --with-libxml2=/var/cfengine --with-libyaml=/var/cfengine --with-librsync=/var/cfengine --with-leech=/var/cfengine --with-libacl=/var/cfengine --without-libvirt --with-libcurl=/var/cfengine --with-postgresql=/var/cfengine --without-mysql --with-cfmod --with-enterprise-api --with-postgresql=/var/cfengine --with-systemd-service --enable-debug
--- Start of Output ---
 ---snip---
configure: error: Cannot find php devel files
--- End of Output (Error Code: 1) ---

@cf-bottom
Copy link

cf-bottom commented Jun 25, 2025

Thanks for submitting a pull request! Maybe @craigcomstock can review this?

@larsewi larsewi marked this pull request as ready for review July 24, 2025 12:04
@larsewi larsewi requested a review from craigcomstock July 24, 2025 12:04
@larsewi larsewi marked this pull request as draft July 25, 2025 11:54
@larsewi larsewi changed the title ENT-12600: configure: Documented script ENT-12600: configure: Documented and refactored script Jul 25, 2025
@larsewi
Copy link
Contributor Author

larsewi commented Aug 4, 2025

Build with no tests
Build Status

@larsewi larsewi marked this pull request as ready for review August 11, 2025 09:06
@larsewi
Copy link
Contributor Author

larsewi commented Aug 25, 2025

Ping @craigcomstock

craigcomstock
craigcomstock approved these changes Aug 25, 2025
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks for this hard work!

larsewi added 9 commits August 26, 2025 09:41
@larsewi
configure: Removed code duplication
e9c69ec 
The code for adding the correct "configure" feature selection options
(i.e., --with-dep=/path/to/dep/, --without-dep) based on the
dependencies had a lot of repetitive code. I created a for loop for
those that are nearly identical.

Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
configure: Reformatted case statements for consistency
a18b775 
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
configure: Remove CODE_COVERAGE build type
255e428 
Because we don't use it.

Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
configure: Fixed some of the shellcheck issues
65a796b 
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
configure: Decrease verbosity of script
05416bf 
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
configure: Documented the script
b3a340b 
Ticket: ENT-12600
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
Always compile with lmdb
3fbeac1 
Ticket: ENT-12600
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
Removed double quotes from configure arguments variable
44fa5ef 
We want word splitting so that the arguments are not interpreted as one
string.

Ticket: ENT-12600
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
configure: Reformatted case statements for consitency
a503c1a 
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
Copy link
Contributor Author

larsewi commented Aug 26, 2025

@cf-bottom Jenkins please :)

@cf-bottom
Copy link

cf-bottom commented Aug 26, 2025

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/12542/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12542/

@larsewi larsewi merged commit b01578e into cfengine:master Aug 27, 2025
28 of 31 checks passed
@larsewi larsewi deleted the configure branch October 2, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craigcomstock craigcomstock craigcomstock approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@larsewi @cf-bottom @craigcomstock